Conversation
Member
|
can this test be added ? --TEST--
dl() does not compile calls to a temporary module's function as frameless
--SKIPIF--
<?php include __DIR__ . "/skip.inc"; ?>
--EXTENSIONS--
opcache
--INI--
enable_dl=1
opcache.enable_cli=1
opcache.opt_debug_level=0x10000
--FILE--
<?php
dl(PHP_OS_FAMILY === 'Windows' ? 'php_dl_test.dll' : 'dl_test.so');
include __DIR__ . '/frameless_temporary.inc';
?>
--EXPECTF--
%A0001 INIT_FCALL 1 %d string("dl_test_frameless")
%Aint(7)
dl_test_frameless(): Argument #1 ($value) must be of type int, string given |
Member
|
fix itself is correct IMO otherwise. |
ndossche
approved these changes
Sep 30, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
I think this is fine. But again this shows what kind of a PITA dl() is.
dl() modules are MODULE_TEMPORARY. Their function records are freed at request shutdown, but zend_flf_functions keeps those pointers for the process lifetime. A later request can match the stale handler address and use the freed record. Temporary modules leave the frameless info unset, so the call uses the ordinary internal path.
iliaal
force-pushed
the
fix/aph-flf-dl-stale-handler
branch
from
September 30, 2026 13:23
5bee9c8 to
49fd095
Compare
Member
Author
|
Added as frameless_temporary_opcache.phpt. |
devnexen
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dl() registers a module as MODULE_TEMPORARY, but zend_register_functions still stored its frameless handlers in the process-global tables. Request shutdown frees those function records, and a later request that maps the extension at the same address dispatches through the freed record. Temporary modules now leave the frameless info unset, so the call uses the ordinary internal path. Persistent modules still receive frameless info. The test skips when setarch -R cannot set the personality, which is what failed the 32-bit CI job.