Repository navigation
Flaky test sequential/test-http2-settings-flood #31107
Description
Activity
I have tested the above on AIX
6.1as well as pLinux on a loop (~400 times) and it always passes.
Could you please add my key to the above machine:ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDQZihjEXcY52UZo09CEb29HwOWwXcmwbwZFR4rsACQQyGUexL4fkVrFfwuG8eV1vg5KECsO8LiGY/MHkNIpABaJJoip0Qxgv0pAFtAukIDjLXXOV/VNJjfIto16vOAehRZkmI+BtQP8TjoT2CSyJgvVQcay8BhH52in1LQQsyCi2crHLYzDrrCgY/rAmuVb1MzMnT8mFOdJ8E5RBhjnmc1K4YBKmNTf6yefgbOJssI0lLzp7Q2uytzp3pipg7AO/VqmRn8953UTJS/cOQeBi3nCYGpz4I7kOKHgwbdW1IP/XFfm0KO5daulHQeToRGIE85ntxF314wsYE3ZyeJwKgHEdit:
Seems like #31146 is causing itGave access, permission already granted in nodejs/build#1706
Seems like #31146 is causing it
@miladfarca Can you figure out why it is crashing?
@addaleax Yes I will be looking into it, might be related to V8 deoptimization
Reacted by Anna HenningsenThis issue doesn't seem to be specific to PPC or AIX. It is also failing on x64-freebsd on the CI: https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd11-x64/30698/console
I have done a debug compile on both
pLinuxandx64 Linuxand this test periodically fails on the same DCHEK:# # Fatal error in ../deps/v8/src/deoptimizer/deoptimizer.cc, line 253 # Debug check failed: code == topmost_ implies safe_to_deopt_. # # # #FailureMessage Object: 0x7ffc4970cda0There seems to be an issue with V8 de-optimizer.
Reacted by Anna HenningsenReacted by Anna Henningsen and Robert Nagy@miladfarca: good job! would you mind creating a V8 ticket?
@ronag I've created this ticket but not sure if we need to reproduce it under V8 (and not nodejs), will wait for their reply:
https://bugs.chromium.org/p/v8/issues/detail?id=10101@miladfarca Same results with a debug build on MacOS Mojave:
$ tools/test.py --mode=debug --repeat 1000 test/sequential/test-http2-ping-flood.js === debug test-http2-ping-flood === Path: sequential/test-http2-ping-flood # # Fatal error in ../deps/v8/src/deoptimizer/deoptimizer.cc, line 253 # Debug check failed: code == topmost_ implies safe_to_deopt_. # # #
- changed the title
[-]Flaky test sequential/test-http2-settings-flood on AIX[/-][+]Flaky test sequential/test-http2-settings-flood[/+]on Jan 8, 2020 Thanks @Trott , just to confirm your mac is x64 correct? I'll add to the V8 ticket.
ping @nodejs/v8
It appears this is already known to be platform agnostic, but just for additional info, it also has been observed on debian9-docker-armv7 (https://ci.nodejs.org/job/node-test-commit-arm/28686/)
FWIW this is also occurring in Ubuntu 18.04 containers.
@addaleax V8 ticket (https://bugs.chromium.org/p/v8/issues/detail?id=10101) is now closed with a comment suggesting an API misuse in node. Issue might be related to this commit/line which might need to be refactored: 7e6104f#diff-9e96b9359319a317a5a1ee45f11eea67R126
Reacted by Anna HenningsenReacted by Anna Henningsen@miladfarca Thanks for the info, I’ll try to come up with a fix. They are right here, but I am surprised that
ArrayBuffer::Detach()is unsafe for calling here.Issue might be related to this commit/line which might need to be refactored: 7e6104f#diff-9e96b9359319a317a5a1ee45f11eea67R126
I’d like to avoid that, and instead try to not perform the invalid V8 call here.
Reacted by Milad Fa- added a commit that references this issue
on Feb 5, 2020
The test in
sequential/test-http2-settings-floodsometimes fails on AIX PPC64 withSIGILLand no other output (about 4/100 times). Bisecting points to @ronag’s cd6b00d, which obviously shouldn’t be causing that issue. It doesn’t reproduce when running the test with--jitless, so my best guess would be that it’s a V8 issue on PPC.I can’t really debug this any further, the issue doesn’t seem to reproduce under gdb and core dumps don’t seem helpful, so it would be great if somebody in @nodejs/platform-aix (@miladfarca?) could take a look. In the short term, I guess we could also revert the commit above, although that’s obviously not ideal.