Repository navigation
fix: do not parse return value of errored tasks - #692
Open
sinnercode228 wants to merge 1 commit into
Open
sinnercode228 wants to merge 1 commit into
sinnercode228 wants to merge 1 commit into
Conversation
When a task fails, the receiver stores a result with `is_err=True` and `return_value=None`. `AsyncTaskiqTask.get_result` still tried to validate that `None` against the task's return annotation, so every failed task with a non-optional return type logged a misleading "Cannot parse return type into ..." warning on the client side. Skip the validation when the result is an error: there is no return value to parse, and the actual failure is already available in `result.error`. Closes: taskiq-python#479
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 68 68
Lines 2659 2659
=======================================
Hits 2270 2270
Misses 389 389 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a task fails, the receiver stores a result with
is_err=Trueandreturn_value=None.AsyncTaskiqTask.get_resultstill tried to validate thatNoneagainst the task's return annotation, so every failed task with a non-optional return type logged a misleading "Cannot parse return type into ..." warning on the client side.Skip the validation when the result is an error: there is no return value to parse, and the actual failure is already available in
result.error.Closes: #479