fix(validation): enforce documented filter prompt limits - #1706
Open
vivekvar-dl wants to merge 1 commit into
Open
vivekvar-dl wants to merge 1 commit into
vivekvar-dl wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filterPromptvaluesnullvalid so callers can clear an existing promptThis is related to #1698, but does not claim to fix the persistence bug because the settings storage handler is not present in this repository. It closes the adjacent validation gap called out in the issue discussion.
Verification
bun test packages/validation/api.test.ts(35 passed)bun run --cwd packages/validation check-typesbun run --cwd packages/lib check-typesgit diff --checkRepository-wide checks
bun run format-lint— blocked by existing repository diagnostics (3 errors and 104 warnings, including Biome schema-version mismatches); no fixes were appliedbun run check-types— blocked in the unchangedpackages/ui/components/shadcn-io/dropzone.tsxbecausereact-dropzoneis not declared/installedbun run build— all 7 build tasks completed successfully; the root command then failed inpostbuildbecause the Sentry upload requires a maintainer auth token