Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SBOM browser is OOMKilled regularly. Almost all
/sbom/traffic comes from crawlers, which request dozens of download links at once, every one of them starts its owncosign verify-attestationprocess.Fixes added to reduce memory usage:
503withRetry-After: 30. 4 slots at about 5s per run still handle around 2900 downloads per hour, the worst hour so far had 645. And the SBOM browser should only be used for manual exploration. Automated SBOM checks in prod clusters for example would run viacosigndirectly, so they are not affected by this limit.robots.txtthat disallows/sbom/: The links already haverel='nofollow', but that's only a hint. This stops at least the crawlers that respectrobots.txt.