Repository navigation
fix: match API routes under server base URL - #2218
Merged
Merged
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 7acd3ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
birkskyum
approved these changes
Jul 20, 2026
2 tasks done
indeyets
added a commit
to indeyets/solid-start
that referenced
this pull request
Sep 23, 2026
Vite accepts `base: "https://cdn…/"` for CDN hosting, and server functions used it as the app origin. An external base says where the assets are and nothing about the app, so the app stays at the root, in dev as well: Vite reduces such a base to its path there, and 2.0.5 happened to mount the app under it. `SERVER_BASE_URL` has named the app base since solidjs#2218, but only API route matching read it, and only when `server.baseURL` was set.
huseeiin
pushed a commit
to huseeiin/solid-start
that referenced
this pull request
Sep 24, 2026
Co-authored-by: Birk Skyum <74932975+birkskyum@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.baseURLto the server handlerBASE_URLas a fallback and avoid partial path-segment matchesCloses #2106.
Testing
pnpm test:ci(69 tests)pnpm typecheckpnpm buildpnpm oxfmt --check packages/start/src/config/index.ts packages/start/src/env.d.ts packages/start/src/server/handler.ts packages/start/src/server/strip-path-base.ts packages/start/src/server/strip-path-base.spec.ts .changeset/tidy-zebras-route.md