Skip to content

feat(dashboards): add empty-state graphic for the dashboard page - #8719

Open
TheodoreSpeaks wants to merge 2 commits into
stagingfrom
feat/cool-diagrams
Open

TheodoreSpeaks wants to merge 2 commits into
stagingfrom
feat/cool-diagrams

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Added a drawn empty-state graphic for the dashboard page — a stat tile, a donut tile, and a trend panel fading off the corner — matching the tables/files/knowledge/logs set (same hairline, ink mixes, and corner fade)
  • DashboardEmptyState lives with the other resource empty states and replaces the bare EmptyState in dashboard-resource.tsx; copy unchanged

Type of Change

  • New feature

Testing

  • Rendered the real component in light and dark next to the existing empty states
  • bun run lint, check:audits (58/58), block-registry check, docs-manifest:check
  • components/dashboards tests pass; root bun run test shows unrelated local failures only (env-dependent rate-limit/timeout tests and load timeouts) — type-check left to CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

https://claude.ai/code/session_01J7A6CWpREr1jiPAdWyTQbA

@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 7, 2026 5:35pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Adds a custom empty-state graphic for dashboards.

The PR appears safe to merge; no blocking issue remains.

Summary

Adds a dashboard empty-state drawing with a stat tile, donut chart, and trend panel. The existing copy stays unchanged.

  • Changes since the previous review make SPARKLINE and TREND readonly and update toPath to accept them. Their coordinates and drawing output stay unchanged.
  • The previous mutable-array finding is fixed.
  • TheodoreSpeaks dismissed the props-interface finding: both components take no props, match sibling components, and empty interfaces would add nothing.
  • No new actionable issues were found.

Reviews (2) · Last reviewed commit: "improvement(dashboards): mark empty-stat..." · Reviewed by Greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — 0b10c6bd Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant