fix(db): pin the primary-key plan in the search retirement read-bound test - #8556
Merged
Merged
Conversation
… test The test disabled only sequential scans, so the planner could still answer a page with a bitmap scan that reads every remaining row. Which plan it chose depended on whether autovacuum had analyzed the fresh fixture rows, making the read-count assertion flaky in CI. Analyze the table and disable bitmap scans too, matching production's primary-key walk.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bounds the IDs each page reads by the row limit once the limit shrinkstest in0027_retire_search_embeddings.integration.ts(failing staging CI withexpected 199619 to be less than 90000)ANALYZE documentand alsoSET enable_bitmapscan = off(reset afterwards), pinning the primary-key walk production uses. Test-only; the migration is unchangedType of Change
Testing
213355reads)packages/dbintegration suite (17 files) against a CI-equivalent pgvector pg17 database provisioned withdb:push213499reads), so it keeps guarding the real regressionChecklist
test-auditauthoring gate)🤖 Generated with Claude Code