improvement(lint): strip comment noise and add check:comment-hygiene - #8551
Conversation
Removes dead sub-block configs from the Human in the Loop and Greptile blocks and an unused commented-out DisplayMode type. The docs generator read the commented-out greptile_search entry in tools.access, so the generated Greptile docs advertised a disabled operation; regenerated.
Fails on banner separator comments and on line comments whose text parses as TypeScript (commented-out code). Comments come from the Babel token stream so strings are never inspected; prose lines split comment groups, and labels, literals and one-off glosses are rejected, giving zero false positives across the tree. Change-history phrasing was measured and left out because most hits describe live state.
Converts decorated section banners to plain comments or drops them, and sweeps the noisiest files for comments that restate the code or name what follows. Field-level notes that carry units, enums or invariants move to TSDoc. Comment-only: the non-comment token stream of every changed file is identical.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 94 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
…buffer, correct ribbon arc note
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
biome-ignore, and// <tag>:annotationgreptile_searchaccess entry fixed generated docs that advertised a disabled Greptile Search operation (regeneratedgreptile.mdxandintegrations.json)check:comment-hygieneaudit: fails on banner separators and on runs of//comments that parse as TypeScript (commented-out code). Comments come from the Babel token stream so strings are never inspected; escape hatch is// comment-hygiene-allow: <reason>. Zero false positives across the tree before the sweep; no baseline since every hit was fixedType of Change
Testing
bun run check:audits,bun run test:scripts(incl. 8 new detector tests, each guard mutation-checked to go red),bun run lint,bunx turbo run type-checkChecklist
test-auditauthoring gate)🤖 Generated with Claude Code