improvement(audits): ratchet unused exports, explicit any, and file names - #8550
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 11 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
check:unused-exports runs knip once with the dead-code issue types gated at zero plus exports/types/duplicates compared against a shrink-only baseline of path#symbol entries. Package entry exports stay public surface via an explicit includeEntryExports: false. run-audits skips check:dead-code since this pass covers it.
… file check:explicit-any runs Biome's noExplicitAny and noNonNullAssertion rules (off repo-wide) and fails when a file's count rises or drops without a baseline update.
check:file-names flags non-kebab-case paths, utils/helpers files that repeat their folder's role, and files that repeat their parent folder's name, with the expected short name in the failure output.
…iome diagnostic exit codes
…on refused updates, flag utils/utils.ts
…ts from the export ratchet knip's dependencies include also reports optionalPeerDependencies, which the strict list dropped. Gate every non-ratchet issue key so a new type fails closed. Generated contract files are excluded via ignoreIssues so rerunning their generators cannot trip the ratchet (359 baseline entries dropped). Print a rename hint when a baselined symbol moves files.
…ssions, name-check root scripts Anchor biome's build/out/uploads ignores to the real output and runtime dirs so apps/sim/lib/uploads and the uploads API routes are linted and counted by check:explicit-any (baseline grows only under those paths). check:explicit-any fails on biome-ignore comments for its two rules. check:file-names scans root scripts/ and vitest.shared.ts, allows Next.js interception segments and dot-prefixed names, ignores the old path of an unstaged mv, and points tool-mandated names at its allowlist. All three ratchets print a rename hint instead of only the shrink instruction.
…ly covered uploads files, anchor suppression detection to comments
92b4510 to
9fec91e
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 17 files
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Fix all with cubic | Re-trigger cubic
…tes, require balanced dynamic segments
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 17 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
This branch was successfully deployed
1 participant
Summary
--update) so the baseline only shrinks:check:unused-exports— knip unused exports, types, and duplicate exports (7,022 baselined). Same knip pass also gates unreachable files/deps, socheck:dead-codeis dropped fromcheck:auditsto avoid running knip twice. Package entry exports stay public (includeEntryExports: false)check:explicit-any— per-file counts of explicitany(3,686) and non-null!(3,440) via one Biome pass (~2.5s)check:file-names— kebab-case, no-utils/-helpersinsideutils//helpers/, and no file that repeats its folder's name in lib/executor/providers/stores/hooks/serializer andpackages/*/src(171 baselined). Failures print the expected short namebun run test, which includestest:scripts(the suite that a workspace-scoped run skips)Type of Change
Testing
bun run check:audits(56/56),bun run test:scripts(341/341),bun run lint,bunx turbo run type-checkany, new unused export, orphan file, camelCase and stuttering file names, stale baseline entryChecklist
test-auditauthoring gate)🤖 Generated with Claude Code