chore(cleanup): apply codebase-design deep-module pass across the monorepo by waleedlatif1 · Pull Request #8549 · simstudioai/sim

waleedlatif1 · 2026-10-01T23:47:35Z

Summary

Deep-module cleanup pass (deletion test, single-adapter seams, pass-throughs) applied repo-wide: delete modules that fail the deletion test, remove single-adapter seams and one-line pass-throughs, and concentrate logic that was copied across callers into one module
Dead code removed (mostly orphaned by the mothership v1.0.0 cutover): lib/platform-context, workflow VFS use cases, unreachable Copilot table/workflow handlers, credential-group invite use cases, table group/column/import use cases, workspace-file orchestration, scheduled-tasks/utils, ~150 unused exports and the mocks/tests that only covered them
Removed the dead isInternalRequest admission bypass in v2 routes — nothing in production marks requests internal, so every request already took the rate-limited path
Deepened shared modules:
- resolvePrincipalWorkflowContext replaces 16 copies of the workflow context resolver
- getCredentialAccessToken replaces 13 copies of the credential→token lookup in webhook subscriptions; toRecord replaces 26 providerConfig casts
- buildJsonSchemaResponseFormat replaces the response_format literal in 11 providers
- escapeLikePattern (@sim/utils/string) replaces 6 LIKE-escape copies; file sniffer reuses zip-guard EOCD parsing
- Subflow node-id codec exports its functions directly; ~25 forwarders removed
- App now uses @sim/workflow-persistence subflow helpers, @sim/auth/principal anonymous user, and @sim/workflow-renderer tile color instead of local copies
- Shared @sim/utils helpers replace ~40 inline toRecord/isRecordLike/sleep/toError copies
Behavior change: a malformed (non-object) webhook providerConfig now reads as {}
Follow-up: the table-update background task now has no producer; kept one release so in-flight runs drain

Type of Change

Chore / refactor (no intended behavior change)

Testing

bunx turbo run type-check (26/26), bun run lint, bun run check:audits (54/54), block-registry check, docs-manifest:check
Full apps/sim vitest suite (3,255 files, 34,516 tests) and all package test suites (18/18)
Six independent audits re-verified reachability of every deletion (string ids, dynamic imports, mocks, Chat tool catalog) and byte-identical behavior of every consolidation; their fixes are included

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

… scheduled-tasks utils

…two helpers

- import subflow helpers from @sim/workflow-persistence/subflow-helpers - drop env-capabilities and service-account-metadata re-export shims - use isWorkflowBlockProtected in block-enablement - move anonymous user identity into @sim/auth/principal - reuse isLightTileColor from @sim/workflow-renderer/tile-icon-color - use @sim/utils sleep/getErrorMessage in sim-cli (bundled) - remove dead normalizeSandboxProvider export

…ep in data drains

… drop dead vanta input-size

…pace permission queries

…slack-search, skills, and selector helpers

Delete test-only Copilot/executor use cases (bulk table rows by filter, credential delete-many, credential-group invite send/link, sandbox and connected-accounts adapters) with their operation entries, the unused public API route wrapper, parseToolRequest, the invitation management error policy, the execution invitation rate limit, and dead table/chat route helpers.

…rkflow context resolver - Delete unreachable platform-context, workflow VFS, deployment-overview, chat undeploy, and Copilot block-output/upstream-reference use cases plus their workflowOperations entries - Delete dead fetch-deadline and scheduling utils and unused exported helpers - Add resolvePrincipalWorkflowContext and use it at the 16 identical resolvers - Share processCodeFailure between the Daytona and E2B adapters - Use escapeRegExp and generateId in place of inline equivalents

…mutation handlers, and param types chore(cleanup): drop unused billing client usage-pill and plan-view exports

…credential token helpers

…orts

…WithNodes type

…nd drop forwarders

…son_schema response format builder

…and search exports

…ilters

…and add its license

… by deleted Copilot commands

… codec and subflow helpers

…ck keys

vercel · 2026-10-01T23:47:40Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Oct 1, 2026 11:58pm UTC

greptile-apps · 2026-10-01T23:52:21Z

Confidence Score: 5/5

[High risk] Reorganizes imports and moves code across module boundaries.

The changes since the previous review appear safe to merge.

Summary

The PR removes unused modules and pass-throughs while consolidating shared workflow, webhook, provider, and utility logic. Since the previous review, it also removes the codebase-design skill and corrects an application-graph test expectation.

_{Reviews (3) · Last reviewed commit: "chore(skills): drop vendored codebase-de..."}

cubic-dev-ai

No issues found across 482 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Re-trigger cubic}

…ixture

waleedlatif1 · 2026-10-01T23:54:57Z

@greptile

waleedlatif1 · 2026-10-01T23:54:58Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-01T23:55:06Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-10-01T23:55:35Z

@greptile

waleedlatif1 · 2026-10-01T23:55:36Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-01T23:55:44Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 478 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Re-trigger cubic}

waleedlatif1 added 28 commits October 1, 2026 16:33

chore(skills): vendor codebase-design deep-module vocabulary skill

39ad75c

chore(cleanup): remove dead client hooks, query exports, and orphaned…

9f718e4

… scheduled-tasks utils

refactor(queries): concentrate workflow search MCP list fetches into …

23eff1b

…two helpers

chore(cleanup): trim log-views to toOverview and use interruptibleSle…

b698002

…ep in data drains

chore(cleanup): use @sim/utils/object helpers in internal clients and…

4af24d4

… drop dead vanta input-size

chore(cleanup): remove dead logs types, organization utils, and works…

f39ba4a

…pace permission queries

chore(cleanup): remove dead custom-tool use cases and unused folder, …

0859414

…slack-search, skills, and selector helpers

chore(cleanup): remove unreferenced Copilot table commands, workflow …

552f6ca

…mutation handlers, and param types chore(cleanup): drop unused billing client usage-pill and plan-view exports

chore(cleanup): share webhook provider config, notification URL, and …

9e779f4

…credential token helpers

chore(cleanup): remove dead billing, credential, MCP, and API key exp…

745079b

…orts

chore(cleanup): remove dead executor helpers and redundant LoopConfig…

0010261

…WithNodes type

refactor(executor): export subflow node-id codec functions directly a…

5887e59

…nd drop forwarders

refactor(providers): drop pass-through model wrappers and share the j…

472a0d0

…son_schema response format builder

chore(cleanup): remove dead executor, tools, and block registry exports

185eab2

chore(cleanup): remove unreachable workspace-file and table use cases

9854071

chore(cleanup): reuse knowledge tag slot constants in the tags service

c484e43

chore(cleanup): share escapeLikePattern from @sim/utils/string

2a805e1

chore(cleanup): reuse zip-guard EOCD parsing in the file sniffer

6594698

chore(cleanup): use isRecordLike for inline record guards

9993fc2

chore(cleanup): remove dead uploads, tokenization, table, knowledge, …

934f384

…and search exports

chore(cleanup): use shared escapeLikePattern in list-query and logs f…

c3aceb6

…ilters

docs(skills): align codebase-design testing guidance with repo rules …

2889452

…and add its license

chore(cleanup): cascade-remove use cases, helpers, and mocks orphaned…

841c34d

… by deleted Copilot commands

chore(cleanup): consolidate shared helpers and restore TSDoc on moved…

81d5f82

… codec and subflow helpers

test(cleanup): port storage-cleanup ownership tests and drop stale mo…

8e326cf

…ck keys

vercel Bot deployed to Preview October 1, 2026 23:50 View deployment

cubic-dev-ai Bot reviewed Oct 1, 2026

View reviewed changes

test(scripts): follow model-access import move in application-graph f…

cd2bd67

…ixture

chore(skills): drop vendored codebase-design skill from the repo

9abbf17

vercel Bot deployed to Preview October 1, 2026 23:58 View deployment

cubic-dev-ai Bot reviewed Oct 1, 2026

View reviewed changes

waleedlatif1 merged commit f7b47bc into staging Oct 2, 2026
27 of 28 checks passed

waleedlatif1 deleted the chore/codebase-design-skill branch October 2, 2026 00:00

waleedlatif1 mentioned this pull request Oct 2, 2026

v0.9.10: geo, chat fixes, sandbox fixes #8539

Merged

Navigation Menu

chore(cleanup): apply codebase-design deep-module pass across the monorepo - #8549

chore(cleanup): apply codebase-design deep-module pass across the monorepo#8549
waleedlatif1 merged 30 commits into
stagingfrom
chore/codebase-design-skill

waleedlatif1 commented Oct 1, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 1, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Oct 1, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

waleedlatif1 commented Oct 1, 2026

Uh oh!

waleedlatif1 commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 1, 2026

Uh oh!

waleedlatif1 commented Oct 1, 2026

Uh oh!

waleedlatif1 commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

waleedlatif1 commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 1, 2026

Uh oh!

waleedlatif1 commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 1, 2026

Uh oh!

waleedlatif1 commented Oct 1, 2026

Uh oh!

waleedlatif1 commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Oct 1, 2026 •

edited

Loading

vercel Bot commented Oct 1, 2026 •

edited

Loading

greptile-apps Bot commented Oct 1, 2026 •

edited

Loading