Skip to content

fix(dashboards): keep DST fall-back range endpoints and resolve threshold axis from first series - #8541

Merged
waleedlatif1 merged 4 commits into
stagingfrom
fix/dashboard-dst-threshold-axis
Oct 1, 2026
Merged

waleedlatif1 merged 4 commits into
stagingfrom
fix/dashboard-dst-threshold-axis

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Dashboard custom-range caption no longer collapses a DST fall-back range into one timestamp when both ends land on the same repeated local minute — both endpoints render separately with seconds and the timezone name (e.g. 01:30:00 EDT – 01:30:59 EST)
  • Threshold validation and placement now resolve the axes the first series is actually plotted on (xAxisId/yAxisId or xAxisIndex/yAxisIndex) instead of always reading axis[0] — a chart with a categorical first y-axis and a value secondary axis is no longer rejected; a missing referenced axis throws
  • Follow-ups to review findings on v0.9.10: geo, chat fixes, sandbox fixes #8539

Type of Change

  • Bug fix

Testing

Added unit tests for both cases; bun run lint, check:audits, and docs-manifest:check pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

https://claude.ai/code/session_014XZeqUthYKiWrLY35SJMEC

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 1, 2026 9:33pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Chart annotation logic for thresholds and dashboard time formatting.

The PR appears safe to merge; no outstanding findings or new actionable issues remain.

Summary

The PR preserves both displayed endpoints when a dashboard range falls within the same local minute, and resolves threshold axes using the first series’ axis references. The latest changes align index-versus-ID precedence and numeric ID matching with the intended ECharts behavior.

Reviews (4) · Last reviewed commit: "fix(charts): resolve threshold axis by i..."

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/charts/annotations.ts Outdated
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/lib/charts/annotations.ts Outdated
Comment thread apps/sim/lib/charts/annotations.test.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/dashboards/time.ts Outdated
Comment thread apps/sim/lib/charts/annotations.ts
Comment thread apps/sim/lib/dashboards/time.ts Outdated
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/charts/annotations.ts Outdated
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit ec1a997 into staging Oct 1, 2026
32 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/dashboard-dst-threshold-axis branch October 1, 2026 21:53

This branch was previously deployed

1 inactive deployment
Preview — ff23cf2f Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants