Skip to content

feat(chat): cycle available composer modes with Shift+Tab - #8511

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/chat-mode-shortcut
Oct 1, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/chat-mode-shortcut

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add Shift+Tab in the focused chat composer to cycle available Search, Build, and Plan modes in dropdown order.
  • Share mode availability between the shortcut and selector, preserve the draft and caret, and keep permission and picker guards while skipping Search when attachments or mentions make it unavailable.
  • Show the shortcut in the mode tooltip for organization and workspace composers.

Type of Change

  • Improvement

Testing

  • 47 composer and sibling tests passing; new mode-cycle regression cases verified failing before implementation.
  • Browser checks using the real organization and workspace composers with fixture data: mode cycling, wraparound, focus and selection, unavailable modes, locked chats, attachment restrictions, mention picker, and ordinary Tab. Saved JSON report and screenshot locally.
  • Cleanup review, app type-check, lint, 53 audits, block registry check, and generated artifact checks passing.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 1, 2026 8:44am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds keyboard shortcut to cycle composer modes.

The PR appears safe to merge; no outstanding findings remain.

Summary

Adds Shift+Tab mode cycling to the organization and workspace chat composers.

  • Shares mode ordering with the selector and skips Search when organization-composer mentions or attachments make it unavailable.
  • Preserves draft focus and selection, adds a tooltip hint, and extends composer tests.

Reviews (2) · Last reviewed commit: "fix(chat): skip unavailable Search durin..."

Comment thread apps/sim/app/o/[organizationId]/home/components/composer/composer.test.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 60a1f6f into staging Oct 1, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/chat-mode-shortcut branch October 1, 2026 17:32

This branch was previously deployed

1 inactive deployment
Preview — 5d0e6000 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant