Skip to content

fix(search): align landing layout and history rows with Home - #8317

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/search-home-alignment
Sep 26, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/search-home-alignment

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Align Search with Home through one shared landing layout; keep history below the composer without shifting its position.
  • Match recently viewed titles and rows to recent-search chips using existing EMCN typography and geometry.
  • Replace the pending search spinner with the workspace chat Stop control, wired to query cancellation even after editing or clearing the draft.

Type of Change

  • Bug fix

Testing

  • 180 tests across 23 files, including a cancellation regression demonstrated failing before the fix.
  • Type-check and lint-check across 26 workspaces; all 51 audits; block registry and generated artifact checks.
  • All nine cleanup passes. Local browser comparison in light/dark, narrow and short layouts, long input, history switching, keyboard actions, and busy state. Heading/input positions match with zero history-tab layout shift.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 26, 2026 5:00am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Refactors landing page layout and search UI components.

The PR appears safe to merge; no new actionable issue or outstanding previous finding was identified.

Summary

The PR shares the Home landing layout with Search, aligns history and source-row styling, and replaces the pending spinner with a Stop control. Since the previous review, it keeps Stop available when the draft changes or is cleared and updates the cancellation regression test.

Reviews (2) · Last reviewed commit: "fix(search): keep cancellation available..."

Comment thread apps/sim/app/o/[organizationId]/search/search.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 240067b into staging Sep 26, 2026
24 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-home-alignment branch September 26, 2026 05:05

This branch was previously deployed

1 inactive deployment
Preview — ae0b109c Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant