Repository navigation
fix(wup): retain dedupe for retryable incident tickets (PLF-146) - #29
Conversation
Co-authored-by: Koru Agent <agent@coru.dev>
There was a problem hiding this comment.
Validator approval after policy checks for exact head 0d27a8dc34dd722acf1022ab2bed4a5d21040310.
Ticket: ticket-146
Correlation ID: local-semcod-wup-pr-29-ticket-146
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The PR correctly updates the list of irreversibly closed statuses in PlanfileReporter to exclude 'failed' and 'blocked', permitting retries as described in the PR body. It also adds a well-structured parameterized unit test to verify this new behavior.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 7b8a2c8084eb5e45d20983b1a4c7665e6228ac9b...0d27a8dc34dd722acf1022ab2bed4a5d21040310
Change digest: 160365fc92acac356ee1b3cdae4af6daf6afd3fb2773c4ac13971262a938f622
Score: 48/100 (M), estimated 46 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":23,"base_sha":"7b8a2c8084eb5e45d20983b1a4c7665e6228ac9b","binary_files":0,"categories":{"code":1,"tests":1},"change_digest":"160365fc92acac356ee1b3cdae4af6daf6afd3fb2773c4ac13971262a938f622","comparison":"7b8a2c8084eb5e45d20983b1a4c7665e6228ac9b...0d27a8dc34dd722acf1022ab2bed4a5d21040310","deletions":4,"file_count":2,"files":["tests/test_planfile_reporter_dedupe.py","wup/planfile_reporter.py"],"head_sha":"0d27a8dc34dd722acf1022ab2bed4a5d21040310","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":46,"within_budget":false},"impact":{"components":["blocked","done","tests","wup"],"files":["blocked/failed","done/canceled","tests/test_planfile_reporter_dedupe.py","wup/planfile_reporter.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":10,"name":"Implement blocked","scope":["blocked"]},{"estimated_minutes":10,"name":"Implement done","scope":["done"]},{"estimated_minutes":10,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":10,"name":"Implement wup","scope":["wup"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-146"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-146: fix(wup): retain dedupe for retryable incident tickets (PLF-146)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 46m</text></svg>DECISION D-146-4603
TICKET ticket-146
HEAD_SHA 0d27a8dc34dd722acf1022ab2bed4a5d21040310
CORRELATION_ID local-semcod-wup-pr-29-ticket-146
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/wup","pull_request":29,"head_sha":"0d27a8dc34dd722acf1022ab2bed4a5d21040310","base_sha":"7b8a2c8084eb5e45d20983b1a4c7665e6228ac9b","diff_sha256":"d06ef6789779e481c08cd0f7bb6cecaaf7bf8ce41be1851a702d550e24b2330b"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["tests/test_planfile_reporter_dedupe.py","wup/planfile_reporter.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"7b8a2c8084eb5e45d20983b1a4c7665e6228ac9b","head_sha":"0d27a8dc34dd722acf1022ab2bed4a5d21040310","change_digest":"160365fc92acac356ee1b3cdae4af6daf6afd3fb2773c4ac13971262a938f622","score":48,"complexity":"M","estimated_minutes":46,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Closes #28. Follow-up to merged #23. Planfile permits retrying blocked/failed; only done/canceled are immutable. Do not cache blocked/failed as closed or create sibling incidents when their timestamps are old. Test-first: 2 regression failures before fix, 115 focused tests and Ruff pass afterwards. Source only; no watcher restart, runtime config edit or hardware effects. Requires protected OneDev Python matrix and independent Validator for the exact head 0d27a8d.