Skip to content

close_old_findings and skip_duplicates should be configurable for Users #26

Open
Open
close_old_findings and skip_duplicates should be configurable for Users#26
Labels
documentationImprovements or additions to documentation

Description

@rfelber
rfelber
opened on Nov 25, 2022

In the current implementation there are two configuration options hardcoded and not configurable for users. Would be great to make them configurable:

defectdojo-client-java/src/main/java/io/securecodebox/persistence/defectdojo/service/ImportScanService.java

Lines 113 to 115 in 073387c

mvn.add("close_old_findings", "true");
mvn.add("skip_duplicates", "false");
mvn.add("test_type", String.valueOf(testType));

Activity

  1. rfelber
    added
    enhancementNew feature or request
    on Nov 25, 2022
  2. rfelber
    added this to secureCodeBoxon Nov 25, 2022
  3. rfelber
    moved this to Backlog in secureCodeBoxon Nov 25, 2022

  4. J12934 commented on Nov 25, 2022

    @J12934
    J12934
    on Nov 25, 2022
    Member

    @rseedorff You should be able to overwrite these by setting the close_old_findings or skip_duplicates in the options MultiValueMap (the last param in the function).
    The options map take precedent over these settings, they are merely the default values.

    This is (like everything in the client) not documented :(

  5. rfelber
    added
    documentationImprovements or additions to documentation
    and removed
    enhancementNew feature or request
    on Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions