Repository navigation
More future.input cleanup work - #2289
Merged
Merged
Conversation
* Add config loading helpers to utils * Add tests for config loading helpers * Add cross-references to doc for OneOrIterableOf
* Rename base Mapping class to InputMapping * Rename input.mapping module to match the base type name * Update imports
…n mapping removal
* Use _T | Iterable[_T] * Remove _T2
pvcraven
added a commit
that referenced
this pull request
Oct 8, 2026
* Make mypy and pyright fail CI, and fix their errors Fixing the type errors turned up three crashes: - Window subclasses that stored a camera as self.camera (platformer tutorial steps 7-19, custom_sprite, the lights tutorial) raised AttributeError on startup. Window.camera is pyglet's default camera. They now use self.world_camera, and assigning Window.camera explains. - pixelated_ui() used pyglet 2 font filter attributes. - InputManager.parse() called a function renamed in #2289. A file-wide type: ignore had hidden it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sort the pyglet.enums import Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Paul V Craven <paul.craven@optimizley.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Cleanup readability and support future improvements
Changes
utils.grow_sequence, supporting predicate functions, and tests for all of theseWhy
Slowly improving input manager quality will make it easier to heavily test cameras.