Skip to content

Transform the inner expression of StarExpr #22131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cherith1222 wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −1
Open

Transform the inner expression of StarExpr #22131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3be726f
Transform inner expression of StarExpr in TreeTransform
Cherith1222 Oct 6, 2026
b0c7abb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mypy/treetransform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,9 @@ def visit_match_stmt(self, o: MatchStmt) -> MatchStmt:
)

def visit_star_expr(self, node: StarExpr) -> StarExpr:
return StarExpr(node.expr)
new = StarExpr(self.expr(node.expr))
new.valid = node.valid
return new

def visit_int_expr(self, node: IntExpr) -> IntExpr:
return IntExpr(node.value)
Expand Down
18 changes: 18 additions & 0 deletions test-data/unit/check-typevar-tuple.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3255,3 +3255,21 @@ class K(Base):
class Base: ...
reveal_type(K.q) # N: Revealed type is "builtins.list[tuple[builtins.bool, builtins.int, builtins.str]]"
[builtins fixtures/tuple.pyi]

[case testUnpackTypeVarTupleInFunctionWithConstrainedTypeVar]
from typing import Generic, TypeVar, Tuple
from typing_extensions import TypeVarTuple, Unpack

T = TypeVar("T")
P = TypeVar("P", int, str)
Ts = TypeVarTuple("Ts")

class Container(Generic[T, P]):
def foo(self) -> T: ...

def f(container: Container[Tuple[Unpack[Ts]], P]) -> None:
result = container.foo()
reveal_type(result) # N: Revealed type is "tuple[Unpack[Ts`-1]]"
y = (*result,)
reveal_type(y) # N: Revealed type is "tuple[Unpack[Ts`-1]]"
[builtins fixtures/tuple.pyi]
Loading