gh-158631: Avoid overflow in logistic and sigmoid KDE kernels - #158632
Closed
mikamikasuki wants to merge 1 commit into
Closed
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
Member
|
Please wait until we discuss this on the issue. |
Member
|
In addition the OP already stated their intent to make a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158631.
The logistic and sigmoid KDE kernels now use stable exponential formulas for their PDFs and CDFs, avoiding overflow for finite query points far from the data.
Validation:
TestKDEclass passed against the current source and tests under Python 3.14 with compatibility shims for math helpers and test support added on CPython main.git diff --checkpassed.