Skip to content

Add support for PEP 646 #87390

Closed
Closed
Add support for PEP 646#87390
Labels
3.11only security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)stdlibStandard Library Python modules in the Lib/ directorytestsTests in the Lib/test dirtopic-typingtype-featureA feature request or enhancement

Description

@mrahtz
mrahtz
mannequin
opened on Feb 14, 2021
BPO 43224
Nosy @gvanrossum, @serhiy-storchaka, @JelleZijlstra, @lysnikolaou, @pablogsal, @Fidget-Spinner, @mrahtz, @mrahtz, @AlexWaygood, @cdce8p
PRs
  • bpo-43224: Initial implementation of PEP 646 in typing.py #24527
  • bpo-43224: Draft implementation of PEP 646 #30398
  • bpo-43224: Implement PEP 646 grammar changes #31018
  • bpo-43224: Implement PEP 646 changes to genericaliasobject.c #31019
  • bpo-43224: Implement PEP 646 changes to typing.py #31021
  • bpo-43224: Implement substitution of unpacked TypeVarTuple #31800
  • bpo-43224: Work around substitution of unpacked TypeVarTuple #31804
  • bpo-43224: Implement substitution of unpacked TypeVarTuple in C #31828
  • bpo-43224: Add more tests for typevar substitution #31844
  • bpo-43224: Fix Tuple[()].__args__ #31845
  • bpo-43224: Add tests for TypeVarTuple substitution in Annotated #31846
  • bpo-43224: Add TypeVarTuple.__name__ #31954
  • bpo-43224: Unpack concrete tuple types into a sequence of types #32030
  • bpo-43224: Forbid TypeVar substitution with Unpack #32031
  • bpo-43224: Implement pickling of TypeVarTuples #32119
  • bpo-43224: Add tests for pickling and copying of unpacked native tuple #32159
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2021-02-14.17:21:47.204>
labels = ['interpreter-core', 'tests', 'library', '3.11']
title = 'Add support for PEP 646'
updated_at = <Date 2022-04-05.02:52:50.682>
user = 'https://github.com/mrahtz'

    bugs.python.org fields:

    activity = <Date 2022-04-05.02:52:50.682>
actor = 'JelleZijlstra'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)', 'Tests', 'Parser']
creation = <Date 2021-02-14.17:21:47.204>
creator = 'mrahtz'
dependencies = []
files = []
hgrepos = []
issue_num = 43224
keywords = ['patch']
message_count = 9.0
messages = ['414715', '414935', '414991', '415514', '416020', '416022', '416074', '416689', '416727']
nosy_count = 10.0
nosy_names = ['gvanrossum', 'serhiy.storchaka', 'JelleZijlstra', 'lys.nikolaou', 'pablogsal', 'kj', 'matthew.rahtz', 'mrahtz', 'AlexWaygood', 'cdce8p']
pr_nums = ['24527', '30398', '31018', '31019', '31021', '31800', '31804', '31828', '31844', '31845', '31846', '31954', '32030', '32031', '32119', '32159']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue43224'
versions = ['Python 3.11']

    Activity

    1. mrahtz
      added
      3.10 (EOL)end of life
      stdlibStandard Library Python modules in the Lib/ directory
      on Feb 14, 2021
    2. mrahtz
      added
      testsTests in the Lib/test dir
      interpreter-core(Objects, Python, Grammar, and Parser dirs)
      3.11only security fixes
      and removed
      3.10 (EOL)end of life
      on Jan 4, 2022
    3. mrahtz
      changed the title [-]Add support for PEP 646 (Variadic Generics) to typing.py[/-] [+]Add support for PEP 646[/+] on Jan 4, 2022
    4. mrahtz
      added
      3.11only security fixes
      and removed
      3.10 (EOL)end of life
      on Jan 4, 2022
    5. mrahtz
      changed the title [-]Add support for PEP 646 (Variadic Generics) to typing.py[/-] [+]Add support for PEP 646[/+] on Jan 4, 2022

    6. JelleZijlstra commented on Mar 8, 2022

      @JelleZijlstra
      JelleZijlstra
      on Mar 8, 2022
      Member

      New changeset 7a793a3 by Matthew Rahtz in branch 'main':
      bpo-43224: Implement PEP-646 changes to typing.py (GH-31021)
      7a793a3

    7. serhiy-storchaka commented on Mar 11, 2022

      @serhiy-storchaka
      serhiy-storchaka
      on Mar 11, 2022
      Member

      New changeset 5b1b9ea by Serhiy Storchaka in branch 'main':
      bpo-43224: Implement substitution of unpacked TypeVarTuple (GH-31800)
      5b1b9ea

    8. 16 remaining items

    9. JelleZijlstra
      added a commit that references this issue on May 2, 2022

      gh-87390: Add __unpacked__ attribute to types.GenericAlias (#92059)

      ff88f7e
    10. serhiy-storchaka
      added 2 commits that reference this issue on May 5, 2022

      pythongh-87390: Fix starred tuple equality and pickling

      5823b5a

      gh-87390: Fix starred tuple equality and pickling (GH-92337)

      1ed8d03

    11. hauntsaninja commented on Oct 11, 2022

      @hauntsaninja
      hauntsaninja
      on Oct 11, 2022
      Contributor

      How much of the checklist above is still relevant?

    12. mrahtz commented on Oct 11, 2022

      @mrahtz
      mrahtz
      on Oct 11, 2022
      ContributorAuthor

      Thanks for the reminder! From a quick look, some of the items in the checklist are definitely still relevant. I'll try and find some time for this soon.

    13. JelleZijlstra
      added 3 commits that reference this issue on Oct 25, 2022

      GH-87390: Add remaining tests for PEP 646 (#98267)

      cb95cc2

      [3.11] pythonGH-87390: Add remaining tests for PEP 646 (pythonGH-98267)

      fc6f7cf

      [3.11] GH-87390: Add remaining tests for PEP 646 (GH-98267) (#98667)

      83c8df2

    14. AlexWaygood commented on Apr 10, 2023

      @AlexWaygood
      AlexWaygood
      on Apr 10, 2023
      Member

      Thanks for the reminder! From a quick look, some of the items in the checklist are definitely still relevant. I'll try and find some time for this soon.

      Friendly ping on this -- are the unchecked items on the checklist still to do, or is this issue ~complete now? :)

    15. mrahtz commented on Apr 10, 2023

      @mrahtz
      mrahtz
      on Apr 10, 2023
      ContributorAuthor

      Whoops, sorry - we finished #98267 last year but I completely forgot to update the checklist. I believe we can go ahead and close this now :) (though I can't seem to do this myself because the issue was created before the move to GitHub or something? Can you do it on your end?)

    16. AlexWaygood commented on Apr 10, 2023

      @AlexWaygood
      AlexWaygood
      on Apr 10, 2023
      Member

      Whoops, sorry - we finished #98267 last year but I completely forgot to update the checklist. I believe we can go ahead and close this now :)

      No worries -- great to hear!

      Can you do it on your end?)

      I sure can. Thanks for all the work you put into this, it was a marathon!

    17. AlexWaygood
      closed this as completedon Apr 10, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.11only security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)stdlibStandard Library Python modules in the Lib/ directorytestsTests in the Lib/test dirtopic-typingtype-featureA feature request or enhancement

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions