Skip to content

if SOURCE_DATE_EPOCH is set, don't randomize the testsuite #110164

Description

@asottile

Feature or enhancement

Proposal:

cc @vstinner from #109570 (comment)

cc @doko42 @stefanor from debian -- this would allow debian to remove this patch I believe https://salsa.debian.org/cpython-team/python3/-/blob/master/debian/patches/test-no-random-order.diff

if SOURCE_DATE_EPOCH is set test randomization should be disabled

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

#109570 (comment)

Linked PRs

Activity

  1. added 2 commits that reference this issue on Oct 1, 2023
  2. vstinner commented on Oct 1, 2023

    @vstinner
    Member

    Would you be able to test if my PR gh-110168 fix your issue?

  3. vstinner commented on Oct 1, 2023

    @vstinner
    Member

    My PR doesn't check SOURCE_DATE_EPOCH value. It only checks if the variable is defined.

  4. asottile commented on Oct 1, 2023

    @asottile
    ContributorAuthor

    @vstinner works great -- thanks!

  5. added a commit that references this issue on Oct 1, 2023
  6. vstinner commented on Oct 1, 2023

    @vstinner
    Member

    Merged, thanks for the test @asottile.

  7. encukou commented on Oct 17, 2023

    @encukou
    Member

    The feature breaks tests, see: #110932
    If we are to maintain this case, it should probably have a buildbot.

  8. vstinner commented on Oct 17, 2023

    @vstinner
    Member

    If we are to maintain this case, it should probably have a buildbot.

    I don't think that a whole buildbot is needed. Just additional tests.

  9. added a commit that references this issue on Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions