Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #586.
French (Switzerland) defines
currencyDecimal = '.', but currency formatting currently uses its ordinary decimal separator,','. For example, USD 12345.678 renders as12'345,68 $USinstead of12'345.68 $US.Use the currency-specific symbol when a currency is supplied to
NumberPattern.apply, passing it through fractional formatting. This covers standard, accounting and long-name currency formats, as well as scientific and significant-digit custom patterns. Ordinary decimal formatting keeps the locale's decimal symbol.Six new regression cases fail before the fix.
Validation:
python -m pytest tests/test_numbers.py -q --tb=short --show-capture=no: 137 passed.AI assistance: Codex prepared the fix and tests and ran the automated checks above. No independent human review is claimed.