Conversation
theofidry
approved these changes
Sep 28, 2026
| // the counter applies only the first limit found, so each is looked up on its own | ||
| // to show a KUBERNETES_CPU_LIMIT that a cgroup quota overrides | ||
| $this->printCores($output, 'cgroup CPU quota: %s', (new CgroupCpuQuotaFinder())->find()); | ||
| $this->printCores($output, 'KUBERNETES_CPU_LIMIT: %s', (new EnvVariableFinder('KUBERNETES_CPU_LIMIT'))->find()); |
Contributor
There was a problem hiding this comment.
The API is private at the moment but I think conceptually it would be more correct to get CpuCoreCounter#countLimitFinder and use the Diagnoser service instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates fidry/cpu-core-counter to 1.4 which added support for cgroups and lets us simplify CPU detection.