Skip to content

Fix #156 - Parser mistakes with comments - #291

Merged
williamdes merged 1 commit into
phpmyadmin:QAfrom
sinri:issue156-mr
Mar 20, 2020
Merged

williamdes merged 1 commit into
phpmyadmin:QAfrom
sinri:issue156-mr

Conversation

@sinri

@sinri sinri commented Feb 11, 2020 •

Copy link
Copy Markdown
Contributor

I have no too much time to research the whole parser but I tried to provide a hot fix on the issue 156.

Fixes: #156

@sinri
sinri requested a review from williamdes February 13, 2020 02:26
@williamdes williamdes self-assigned this Mar 20, 2020
@williamdes williamdes added this to the 4.5.1 milestone Mar 20, 2020
@williamdes
williamdes changed the base branch from master to QA March 20, 2020 18:25
@williamdes williamdes changed the title Fix #156 Fix #156 - Parser mistakes with comments Mar 20, 2020
@williamdes
williamdes merged commit a2d0b76 into phpmyadmin:QA Mar 20, 2020
@williamdes

Copy link
Copy Markdown
Member

Merged, thank you @sinri !

williamdes added a commit that referenced this pull request Mar 20, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes

Copy link
Copy Markdown
Member

I added 833fb1e to fix failing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parser mistakes with comments

2 participants