Skip to content

fixes ALTER TABLE ... PRIMARY/UNIQUE KEY "Missing comma" error - #268

Merged
williamdes merged 6 commits into
phpmyadmin:masterfrom
MisterCoder:master
Nov 13, 2019
Merged

williamdes merged 6 commits into
phpmyadmin:masterfrom
MisterCoder:master

Conversation

@MisterCoder

Copy link
Copy Markdown

Fixes #267

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@codecov

codecov Bot commented Nov 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #268 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #268   +/-   ##
=========================================
  Coverage     99.54%   99.54%           
  Complexity     1860     1860           
=========================================
  Files            63       63           
  Lines          4132     4132           
=========================================
  Hits           4113     4113           
  Misses           19       19

@devenbansod
devenbansod self-requested a review November 13, 2019 15:16

@devenbansod devenbansod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamdes williamdes self-assigned this Nov 13, 2019
@williamdes williamdes added this to the 4.4.1 milestone Nov 13, 2019
…ing comma" error

Fixes: phpmyadmin#267
Signed-off-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
williamdes merged commit a82bd61 into phpmyadmin:master Nov 13, 2019
@williamdes

williamdes commented Nov 13, 2019 •

Copy link
Copy Markdown
Member

Thank you for your contribution @MisterCoder !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ALTER TABLE ... PRIMARY/UNIQUE KEY results in error

4 participants