Fix GH-23626: OPcache: orphaned temporaries cause leaks and assertions - #24069
Open
khaledalam wants to merge 1 commit into
Open
khaledalam wants to merge 1 commit into
khaledalam wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
matchhas arms but constant folding proves none of them can be taken, the block pass treatsMATCH_ERRORas a terminator and drops the following blocks as unreachable. Temporaries created before thematchand consumed only in those blocks lose their live range, so:UnhandledMatchErrorunwinds (memory leak, wrong destructor order), orBIND_LEXICALremains,zend_calc_live_ranges()hits thekeeps_op1_alive()assertion.This was already handled for arm-less
matchby markingMATCH_ERRORas an expression throw (ZEND_THROW_IS_EXPR), which stops the CFG from treating it as a block terminator. This patch applies the marking unconditionally, as suggested by @ndossche in the issue.Before
After
Output now matches running without opcache.