JIT: Add fast path for object arguments in RECV - #24052
Merged
Merged
Conversation
Member
Author
|
CI Failures (so far) are unrelated |
AWS x86_64 (c6id.metal)
Laravel 12.11.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)
Symfony 2.8.0 demo app - 50 iterations, 50 warmups, 100 requests (sec)
Wordpress 6.9 main page - 50 iterations, 20 warmups, 20 requests (sec)
bench.php - 50 iterations, 20 warmups, 2 requests (sec)
micro_bench.php - 50 iterations, 5 warmups, 1 request (sec)
|
ndossche
force-pushed
the
jit-faster-recv
branch
from
October 1, 2026 20:57
c4d5d96 to
c3280b8
Compare
arnaud-lb
approved these changes
Oct 2, 2026
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
Looks great!
As a follow-up, I think that we could remove the type_mask branch in zend_jit_verify_arg_type() when type == IS_OBJECT and the type_mask doesn't contain MAY_BE_OBJECT.
| static bool zend_jit_class_is_persistent(const zend_class_entry *ce) | ||
| { | ||
| if (ce->type == ZEND_INTERNAL_CLASS) { | ||
| #ifdef _WIN32 |
Member
There was a problem hiding this comment.
Nit: I know this is a copy/paste, but we should really use ZEND_OPCACHE_SHM_REATTACHMENT here
| { | ||
| if (ce->type == ZEND_INTERNAL_CLASS) { | ||
| #ifdef _WIN32 | ||
| /* ASLR, see zend_jit_class_may_be_modified() */ |
Member
There was a problem hiding this comment.
Typo:
Suggested change
| /* ASLR, see zend_jit_class_may_be_modified() */ | |
| /* ASLR, see zend_jit_may_be_modified() */ |
Member
Author
|
Thanks @arnaud-lb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.