Repository navigation
Conversation
phpGH-23962 stopped a persistent PDO instance from rolling back a connection another instance still holds, but its destruction still ran the driver's persistent_shutdown handler and released the handle's failed query statement. The surviving instance then lost the SQLite functions and collations registered through the destroyed one, and its errorCode() and errorInfo() reverted to 00000. Both now wait for the last instance, like the rollback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-23962 (#23963) made
pdo_dbh_free_storage()skip the rollback while another PDO instance still holds the persistent connection, but the same teardown still runs the driver's persistent_shutdown handler and releases the handle's failed query statement. Destroying one of two persistent SQLite instances therefore unregisters the functions and collations the other one relies on, and resets its errorCode()/errorInfo() to 00000. Both now use the same last-owner check as the rollback, so they run once when the final instance is freed. Drivers whose persistent_shutdown is NULL (pgsql, odbc, firebird, dblib) are unaffected, and mysqlnd's end_psession is deferred the same way.