Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
As suggested in #256, the first commit adds tests: one with a circular redirection over two hops through the real
$firstcallable, which already passes, and two where a new chain reuses the$firstinstance of a finished chain (ending with a response, then with an exception). Both fail on 2.x with "Circular redirection detected".The second commit makes the call that starts a chain remove its entry from
$circularDetectionin afinally, so a reused identifier starts from an empty history and finished chains no longer stay in memory. The line number of the anonymous class inphpstan.neon.distmoves from 221 to 229.Checklist