Skip to content

Testing and CI for image #3

Description

@ketchoop
No description provided.

Activity

  1. ptejada commented on Jan 11, 2019

    @ptejada

    How can I assign this ticket to myself?

  2. assigned and unassigned on Jan 11, 2019
  3. corpsee commented on Jan 11, 2019

    @corpsee
    Member

    @ptejada Done.

  4. ptejada commented on Jan 12, 2019

    @ptejada

    I tried the installation in Windows with the Docker Toolbox v18.03. The installation went smoothly.

    A few things that can be improved:

    1. Upgrade the docker composer file version to 3.
    2. Providing DB options is unnecessary. It should be assumed that if the consumer will be using the DB it will only be used for the PHP Censor software. If the consumer requires a specific DB they should provide it to the worker.
    3. By default, the DB container should be set up with a volume for storage. Otherwise, the database is lost when the container is disposed or rebuild.

    Things I did not test:

    • Large test suites.
    • Multi worker and running build in parallel.
  5. corpsee commented on Jan 12, 2019

    @corpsee
    Member

    @ptejada Thank you for the massive testing! 👍 Could you create issues or PRs for all your points please?

  6. removed their assignment
    on Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions