Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #110, addressing the optional dev middleware issue raised by @offendingcommit during review. Thanks for reviewing and merging the original PR!
server.config.base, so a dev server started with--base /honcho/forwards/honcho/api/*correctly./and/honcho/, verifying that the upstream receives the correct path and query string.Testing
/case passed and the/honcho/case failed: the request returned the SPA HTML instead of the upstream response.make ci-webpassed with all tasks executed: lint, typecheck, 116 existing tests, two proxy regression tests, and production build.git diff --checkpassed.