Repository navigation
[v24.x] deps: V8: cherry-pick ea9c016f26ad - #66570
Closed
richardlau wants to merge 1 commit into
Closed
richardlau wants to merge 1 commit into
richardlau wants to merge 1 commit into
Conversation
Original commit message:
AIX: Fix race condition in DecommitPages
The current implementation of DecommitPages could lead to a race
condition where another thread maps the same region of memory right after we unmap it.
This is currently causing test failures on Node.js:
nodejs#62647
As a workaround we avoid unmapping the address space and instead
mark the region as inaccessible using mprotect. We originally
considered using madvise to release physical memory, but it is a
no-op on AIX and was omitted from this implementation.
IT:105
Change-Id: I8271a562be2e7ebcb685a2dd3b7425a38bebe1c9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8193436
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Milad Farazmand <mfarazma@ibm.com>
Cr-Commit-Position: refs/heads/main@{#109206}
Refs: v8/v8@ea9c016
Signed-off-by: Richard Lau <richard.lau@ibm.com>
richardlau
added
aix
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
aduh95
approved these changes
Oct 10, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Contributor
|
Landed in b8db004 |
aduh95
pushed a commit
that referenced
this pull request
Oct 11, 2026
Original commit message:
AIX: Fix race condition in DecommitPages
The current implementation of DecommitPages could lead to a race
condition where another thread maps the same region of memory right after we unmap it.
This is currently causing test failures on Node.js:
#62647
As a workaround we avoid unmapping the address space and instead
mark the region as inaccessible using mprotect. We originally
considered using madvise to release physical memory, but it is a
no-op on AIX and was omitted from this implementation.
IT:105
Change-Id: I8271a562be2e7ebcb685a2dd3b7425a38bebe1c9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8193436
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Milad Farazmand <mfarazma@ibm.com>
Cr-Commit-Position: refs/heads/main@{#109206}
Refs: v8/v8@ea9c016
Signed-off-by: Richard Lau <richard.lau@ibm.com>
PR-URL: #66570
Refs: #62647
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@ea9c016
Refs: #62647
This is a backport of the referenced upstream V8 commit. It is similar to, but slightly different, to the change that landed on
main/v26.xunder #61898 (that PR is semver-major but this particular change is not). (The difference is due tomadvisebeing a no-op on AIX so was dropped from the upstream V8 CL.)