Repository navigation
Conversation
|
Review requested:
|
Added two new getter properties to `URL::pathname` property: 1. `basename` 1. `extname`
|
These changes don't seem to be part of the standard? |
anonrig
left a comment
There was a problem hiding this comment.
This change is against the WHATWG URL standard. Pathname getter is defined in the spec: https://url.spec.whatwg.org/#dom-url-pathname
|
Yes, you are right. My implementation is merely the result from a discussion in issue #47756. It's a work in progress; a draft; a suggestion; a quick shot; to be discussed. From the NodeJS source code I expected that the project is using its own URL implementation. So, I extended the original implementation, not altering its main interface. Which kind of changes would you like me to implement? |
|
Anything we add to the |
Added two new getter properties to
URL::pathnameproperty:basenameextnameFixes: #47756