Skip to content

path: add path.glob - #47490

Closed
MoLow wants to merge 3 commits into
nodejs:mainfrom
MoLow:add-path-glob
Closed

MoLow wants to merge 3 commits into
nodejs:mainfrom
MoLow:add-path-glob

Conversation

@MoLow

@MoLow MoLow commented Apr 9, 2023 •

Copy link
Copy Markdown
Member

an alternative for #47486 (suggested at #40731 (comment))

as my experience in cpp is much more limited than in js - this code probably has many issues, so feel free to comment on anything.

the glob implementation is used from the linux kernel, it complies with https://man7.org/linux/man-pages/man7/glob.7.html, and is licenced under MIT

this implementation lacks some features that minimatch has such as brace expansion, but according to my tests Python comes with a similar implementation: https://docs.python.org/3/library/glob.html

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.