Skip to content

Investigate flaky tests on FreeBSD #8949

Closed
Closed
Investigate flaky tests on FreeBSD#8949
Labels
child_processIssues and PRs related to the child_process subsystem.freebsdIssues and PRs related to the FreeBSD platform.httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.timersIssues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().

Description

@mscdex
mscdex
opened on Oct 6, 2016
  • Version: master
  • Platform: freebsd
  • Subsystem: child_process, http, timers

I saw these three unrelated tests fail recently on CI: https://ci.nodejs.org/job/node-test-commit-freebsd/4650/nodes=freebsd10-64/console

  • parallel/test-child-process-fork-dgram
not ok 129 parallel/test-child-process-fork-dgram
# TIMEOUT
  ---
  duration_ms: 60.55
  • parallel/test-http-server-consumed-timeout
not ok 546 parallel/test-http-server-consumed-timeout
# 
# assert.js:85
#   throw new assert.AssertionError({
#   ^
# AssertionError: Request timeout should not fire
#     at Object.exports.fail (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common.js:443:10)
#     at IncomingMessage.req.setTimeout (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-http-server-consumed-timeout.js:13:12)
#     at emitOne (events.js:96:13)
#     at IncomingMessage.emit (events.js:188:7)
#     at Socket.<anonymous> (_http_server.js:310:50)
#     at emitNone (events.js:86:13)
#     at Socket.emit (events.js:185:7)
#     at Socket._onTimeout (net.js:342:8)
#     at ontimeout (timers.js:365:14)
#     at tryOnTimeout (timers.js:237:5)
  ---
  duration_ms: 1.943
  • parallel/test-timers-same-timeout-wrong-list-deleted
not ok 970 parallel/test-timers-same-timeout-wrong-list-deleted
# 
# assert.js:85
#   throw new assert.AssertionError({
#   ^
# AssertionError: Elapsed time does not include second timer's timeout.
#     at process.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-timers-same-timeout-wrong-list-deleted.js:26:10)
#     at emitOne (events.js:101:20)
#     at process.emit (events.js:188:7)
  ---
  duration_ms: 1.69

Activity

  1. mscdex
    added
    httpIssues and PRs related to the http subsystem.
    child_processIssues and PRs related to the child_process subsystem.
    timersIssues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().
    testIssues and PRs related to Node.js core tests and test infrastructure.
    freebsdIssues and PRs related to the FreeBSD platform.
    on Oct 6, 2016

  2. jasnell commented on Oct 7, 2016

    @jasnell
    jasnell
    on Oct 7, 2016
    Member

    Seeing this also: https://ci.nodejs.org/job/node-test-commit-freebsd/4673/nodes=freebsd10-64/console

    not ok 970 parallel/test-timers-same-timeout-wrong-list-deleted
# 
# assert.js:85
#   throw new assert.AssertionError({
#   ^
# AssertionError: Elapsed time does not include second timer's timeout.
#     at process.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-timers-same-timeout-wrong-list-deleted.js:26:10)
#     at emitOne (events.js:101:20)
#     at process.emit (events.js:188:7)
  ---
  duration_ms: 1.71
  ...

  3. Trott commented on Oct 7, 2016

    @Trott
    Trott
    on Oct 7, 2016
    Member

    And this: https://ci.nodejs.org/job/node-test-commit-freebsd/4670/nodes=freebsd10-64/console

    not ok 856 parallel/test-net-write-after-close
# TIMEOUT
# about to try to write
  ---
  duration_ms: 60.135

  4. jbergstroem commented on Oct 7, 2016

    @jbergstroem
    jbergstroem
    on Oct 7, 2016
    Member

    Might be worth mentioning that I've seen increased amounts of processes lingering. Usually a bad sign as well as increasing the failure rate of future tests.

  5. Trott commented on Oct 7, 2016

    @Trott
    Trott
    on Oct 7, 2016
    Member

    Yeah, I kind of suspect that when we see three tests failing, that the first one failed and didn't get cleaned up, and that's what's making the subsequent ones fail. Not always the case, but often enough...

  6. jbergstroem commented on Oct 7, 2016

    @jbergstroem
    jbergstroem
    on Oct 7, 2016
    Member

    I cleaned a host and ran a test against master. Here's the failed tests:

    not ok 131 parallel/test-child-process-fork-dgram
not ok 247 parallel/test-dgram-send-callback-multi-buffer
not ok 454 parallel/test-http-client-timeout-with-data
not ok 545 parallel/test-http-server-consumed-timeout
not ok 962 parallel/test-timers-blocking-callback

    stalled processes after that run:

    parallel/test-child-process-fork-dgram.js child
  7. Trott
    added 2 commits that reference this issue on Oct 14, 2016

    test: fix flaky test-child-process-fork-dgram

    0e7c93b

    test: fix flaky test-child-process-fork-dgram

    03afecd
  8. Trott
    closed this as completedin 03afecdon Oct 18, 2016
  9. jasnell
    added a commit that references this issue on Oct 18, 2016

    test: fix flaky test-child-process-fork-dgram

    0f2f4d2
  10. Trott
    added 2 commits that reference this issue on Nov 12, 2016

    test: fix flaky test-child-process-fork-dgram

    0d314aa

    test: fix flaky test-child-process-fork-dgram

    98ce7fe
  11. MylesBorins
    added 2 commits that reference this issue on Nov 14, 2016

    test: fix flaky test-child-process-fork-dgram

    4a6bd86

    test: fix flaky test-child-process-fork-dgram

    6f78089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    child_processIssues and PRs related to the child_process subsystem.freebsdIssues and PRs related to the FreeBSD platform.httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.timersIssues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions