Skip to content

dtrace probe removal broke Windows builds #698

Description

@rvagg

This is blocking release, I believe it's due to:

src: Remove unused Dtrace probes. #694

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/145/nodes=iojs-win2012r2/console

@thekemkid @bnoordhuis please address this, it'll hold up 1.1.0.

Activity

  1. added this to the milestone on Feb 3, 2015
  2. cjihrig commented on Feb 3, 2015

    @cjihrig
    Contributor

    @rvagg check out #700. If this is holding up the release and makes the CI happy, feel free to land it. Otherwise, feel free to close it.

  3. rvagg commented on Feb 3, 2015

    @rvagg
    MemberAuthor

    will leave the call to @chrisdickinson on that as this is his release, I'm happy with a plain revert

  4. GlenTiki commented on Feb 3, 2015

    @GlenTiki
    Contributor

    You can revert it and I'll review the issue

  5. changed the title [-]dtrace prove removal broke Windows builds[/-] [+]dtrace probe removal broke Windows builds[/+] on Feb 3, 2015
  6. cjihrig commented on Feb 3, 2015

    @cjihrig
    Contributor

    @rvagg can this be closed since #703 was merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions