Repository navigation
Possible Windows Node 6 regression with spawn and a substed drive #6500
Description
Activity
This may be related to #5950.
Wow! I'm amazed.
@xzyfer can you rename the issue to "substed" ? (or reference "drive created by subst.exe") - only few MS-DOS die-hards like me remember, what a "substed drive" is.
Reacted by Stephen Edgar- changed the title
[-]Possible Windows Node 6 regression with spawn and subset[/-][+]Possible Windows Node 6 regression with spawn and a substed drive[/+]on May 1, 2016 updated
- addedchild_processIssues and PRs related to the child_process subsystem.Issues and PRs related to the child_process subsystem.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
on May 1, 2016 - added a commit that references this issue
on May 2, 2016 Nice find @saper
19 remaining items
See: #6537
Could you just add an additional
requireto get around theisMainissue?I'd be +1 to removing the
isMainflag and never using realpath at all, by default. Not sure what the consequences of that would be, however.@dlongley node needs to use realpath not to try to load the same binary module twice. It's clunky, but that's how it currently works...
node needs to use realpath not to try to load the same binary module twice. It's clunky, but that's how it currently works...
Then we should only do
realpathon binary modules.@saper Earlier in this thread I asked if the same test case worked with node 6.0.0 with a symlink instead of
SUBST. Just wanted to confirm that this is true or if I misinterpreted you. Just trying to determine the scope of the issue and whether symlinks are a workaround.I have not tried to reproduce it with symlinks before, I have only used
SUBST.EXE.But yesterday I wrote a test case for node to check for this issue and I have made the test case use
MKLINK.EXE(the symbolic linking on Windows) if it gets administrative privileges. The symptoms are the same (it does not matter if one usesSUBSTorMKLINK).@xzyfer can you please try v6.2.0 and see if the problem still exists? Thanks!
Reacted by Alexander Gugel@evanlucas I can confirm this is fixed in Node v6.2.0 in both my reduced reproduction and in the larger node-sass ci.
Glad to hear. Closing as this has been fixed. Thanks!!
- added a commit that references this issue
on Dec 10, 2016
v6.0.0
Windows 32 and 64 bit
I've noticed a minor breaking change in either
child_process.spawnorpath.resolve(currently unclear), on Windows with Node 6. This issue appears to crop up when a Node script is execute from aSUBST'd path.The production steps are tricky so I have created a reproduction in a repo that runs its tests in AppVeyor.