Repository navigation
--experimental-strip-types default value should depend on --without-amaro configure flag #60640
Description
Activity
I think we should skip failing tests when compiled without amaro, do you have a list?
For node 22.21.1 it would be
parallel/test-cli-node-options-docs
parallel/test-config-file
parallel/test-util-getcallsites
parallel/test-worker-eval-typescript
parallel/test-node-output-eval
parallel/test-worker-cli-options
parallel/test-worker-load-file-with-extension-other-than-js
parallel/test-node-output-sourcemaps
parallel/test-runner-outputI'll add this as good first issue since I dont have time to do this but steps are simple:
- build node without amaro:
./configure --without-amaro - compile and run test:
make test - add the
if (!process.config.variables.node_use_amaro) common.skip('Requires Amaro');to failing tests (make sure these tests are failing because of amaro)
And also in another commit:
set the default value of--strip-typesto false ifHAVE_AMAROis not true (this can be done innode_options.cc)- build node without amaro:
Hi @marco-ippolito , could I contribute to this issue by creating a PR? I'm new to this repository, and it would be great if I could contribute to this issue as my first issue—many thanks for considering my request.
Hi @marco-ippolito , could I contribute to this issue by creating a PR? I'm new to this repository, and it would be great if I could contribute to this issue as my first issue—many thanks for considering my request.
You are welcome to open a pull request
Reacted by Yuki OkitaThank you! I'll comment here once I create a PR
Hi @marco-ippolito , I created a PR for this issue. Appreciate your review. Thanks in advance! #60815
- added a commit that references this issue
on Nov 28, 2025 - added a commit that references this issue
on Nov 29, 2025 - added a commit that references this issue
on Jan 9, 2026 - added a commit that references this issue
on Jan 13, 2026 - added a commit that references this issue
on Jan 19, 2026 - added a commit that references this issue
on Feb 17, 2026
Version
git november 8 2025
Platform
Subsystem
No response
What steps will reproduce the bug?
Build with --without-amaro flag,
several tests will fail (parallel/test-worker-syntax-error is an example).
How often does it reproduce? Is there a required condition?
Always
What is the expected behavior? Why is that the expected behavior?
--experimental-strip-types defaults to true, but when compiled without amaro,
it should default to false.
What do you see instead?
Tests failures, in particular with workers.
Additional information
Maybe it's only a problem with workers.
It's easy to spot