Repository navigation
recursive option of fs.readdir results in blocking synchronous I/O instead of async readdir #51749
Closed as not planned
Description
Activity
the recursive watching is done synchronously to avoid timing conditions.
see #51406That issue is about
fs.watch, which is independent offs.readdir. If someone really cares about the state synchronously, then they could callfs.readdirSyncinstead.feel free to open a PR for adjusting the docs
I filed this issue to request documentation of the fact that there is unbounded sync I/O operation in a supposedly async API. Secondly, I am asking for the symlink behavior to be documented because of security implications when the behavior is undefined.
What is the purpose of the documentation issue template if you close such issues before resolution?
Affected URL(s)
https://nodejs.org/api/fs.html#fspromisesreaddirpath-options
Description of the problem
The
readdirmethod specifies arecursiveoption that "reads the contents of a directory recursively". This can be a potentially expensive/long-running filesystem query.The current implementation is synchronous (see below), which means that passing
recursive:truewould block the calling thread until the I/O completes. Ideally, the implementation would not block the calling thread, but until that is implemented (I didn't find any open issue), the least that can be done is to update the documentation to warn about this risk.Another aspect worth documenting is to explicitly call out that symlinks are NOT followed. If symlinks were to be followed, then that could potentially result in security issues, such as DoS (infinite readdir loop) or directory traversal outside of the specified directory.
Relevant issues / PRs that introduced this feature:
Relevant source:
node/lib/fs.js
Lines 1458 to 1467 in 544cfc5