Skip to content

wpt/test-structured-clone is flaky #49852

Closed
#50026
Closed
wpt/test-structured-clone is flaky#49852
#50026
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.linuxIssues and PRs related to the Linux platform.windowsIssues and PRs related to the Windows platform.

Description

@joyeecheung
joyeecheung
opened on Sep 25, 2023

Test

wpt/test-structured-clone

Platform

Linux ARM64, Linux x64, Windows

Console output

01:13:46     [UNEXPECTED_FAILURE][FAIL] Blob unpaired high surrogate (invalid utf-8)
01:13:46     promise_test: Unhandled rejection with value: object "Error: Unable to deserialize cloned data."
01:13:46         at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
01:13:46     Command: /home/iojs/build/workspace/node-test-commit-linux/out/Release/node  /home/iojs/build/workspace/node-test-commit-linux/test/wpt/test-structured-clone.js 'structured-clone.any.js'
01:13:46
Reason wpt/test-structured-clone
Type JS_TEST_FAILURE
Failed PR 5 (#49559, #49745, #48434, #49778, #49790)
Appeared test-ibm-alpine315_container-x64-1, test-rackspace-win2019_vs2019-x64-2, test-equinix-ubuntu2004_container-armv7l-1, test-equinix-ubuntu2004_container-armv7l-2, test-digitalocean-ubuntu1804_sharedlibs_container-x64-3
First CI https://ci.nodejs.org/job/node-test-pull-request/54106/
Last CI https://ci.nodejs.org/job/node-test-pull-request/54166/

Additional information

nodejs/reliability#675

Activity

joyeecheung
added
flaky-testIssues and PRs involving tests that fail intermittently in CI.
on Sep 25, 2023
github-actions
added
linuxIssues and PRs related to the Linux platform.
windowsIssues and PRs related to the Windows platform.
on Sep 25, 2023

joyeecheung commented on Sep 25, 2023

@joyeecheung
joyeecheung
on Sep 25, 2023
MemberAuthor

It seems strange that this is a flake, the error should be thrown by V8 when the object cannot be deserialized somehow.

Unfortunately we don't have a lot of information about where the exception comes from, the JS stack is lost due to asynchronicity, maybe we can tweak the wpt harness a bit to capture the stack (not sure if it's already lost by then though)

joyeecheung commented on Sep 25, 2023

@joyeecheung
joyeecheung
on Sep 25, 2023
MemberAuthor

cc @legendecas as you've recently touched the serdes part

debadree25 commented on Sep 26, 2023

@debadree25
debadree25
on Sep 26, 2023
Contributor

I wonder if could be related to #49713 compare_Blob function uses Response().arrayBuffer() which internally would be using streams to get the data. will try to reproduce this

joyeecheung commented on Sep 26, 2023

@joyeecheung
joyeecheung
on Sep 26, 2023
MemberAuthor

That could be a cause, we can try stress-testing a revert

debadree25 commented on Sep 26, 2023

@debadree25
debadree25
on Sep 26, 2023
Contributor

Does it not seem to be happening on macos? I tried locally with --repeat 1000 but no reproduction would be weird if this was os specific

legendecas commented on Oct 2, 2023

@legendecas
legendecas
on Oct 2, 2023
Member

Sorry for the delay, I was on a trip last week. I'm going to take a look as soon as possible.

nodejs-github-bot
closed this as completedin #50026on Oct 10, 2023
nodejs-github-bot
added a commit that references this issue on Oct 10, 2023

src: avoid making JSTransferable wrapper object weak

78a1570
debadree25
added a commit that references this issue on Apr 15, 2024

src: avoid making JSTransferable wrapper object weak

b27b3a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.linuxIssues and PRs related to the Linux platform.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions