Repository navigation
Symbol.{ dispose, asyncDispose } have incorrect descriptors #48699
Description
Activity
- added a commit that references this issue
on Jul 7, 2023 this is a polyfill until V8 implements explicit resource management, but perhaps we can solve this until than
@ljharb your fix looks good, open a PR?
Reacted by Jordan Harbandoh I just saw #48703 nvm :D
Reacted by Jordan Harband- added a commit that references this issue
on Jul 12, 2023 - added a commit that references this issue
on Jul 13, 2023 - added a commit that references this issue
on Nov 27, 2023 - added a commit that references this issue
on Dec 25, 2023
Version
20.4.0
Platform
All
Subsystem
No response
What steps will reproduce the bug?
`Object.getOwnPropertyDescriptor(Symbol, 'dispose');
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
Object.getOwnPropertyDescriptor(Symbol, 'dispose'); // => {value: Symbol(Symbol.dispose), writable: false, enumerable: false, configurable: false}All well-known symbols should be non-writable, non-enumerable, and non-configurable to avoid patching and breaking things.
What do you see instead?
Object.getOwnPropertyDescriptor(Symbol, 'dispose'); // => {value: Symbol(Symbol.dispose), writable: true, enumerable: true, configurable: true}Additional information
No response