Skip to content

getPeerX509Certificate() supports getting chain of certificates #44905

Description

@vinayak-kukreja

What is the problem this feature will solve?

Trying to verify if a certificate is a root certificate involves having the subject and the issuer as same in PeerCertificate and knowing the the certificate was signed by CA.
I see we can get a chain of certificates using getPeerCertificate(true) but it does not have a property to verify if ca: true like the X509Certificate.

What is the feature you are proposing to solve the problem?

Wondering if it would be possible to either include this property in PeerCertificate or allowing chaining in getPeerX509Certificate().

What alternatives have you considered?

I did not find a way to verify ca: true in PeerCertificate. Let me know if you believe this can be done with current chaining that is available.

Activity

  1. bnoordhuis commented on Oct 9, 2022

    @bnoordhuis
    Member
  2. added
    tlsIssues and PRs related to the tls subsystem.
    on Oct 9, 2022
  3. vinayak-kukreja commented on Oct 10, 2022

    @vinayak-kukreja
    Author

    Thank you for working on this, really appreciate it. :)
    I see the PR has multiple approvals, is there a timeline followed for merging and deploying the change?

  4. jasnell commented on Oct 10, 2022

    @jasnell
    Member

    PRs stay open a minimum of 48 hours in general and must pass CI before they can land.

  5. vinayak-kukreja commented on Oct 17, 2022

    @vinayak-kukreja
    Author

    Hey, following up here. When could it be possible to get this merged?

  6. moved this to Pending Triage in Node.js feature requestson Oct 22, 2022
  7. vinayak-kukreja commented on Oct 28, 2022

    @vinayak-kukreja
    Author

    Hey, any updates about when the fix can be merged?

  8. moved this from Awaiting Triage to Done in Node.js feature requestson Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestIssues requesting new Node.js features.tlsIssues and PRs related to the tls subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions