Skip to content

FTBFS with GCC 13 #43642

Description

@marxin

Version

No response

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

Building with GCC 13 (current master):

[   38s] In file included from ../deps/v8/src/base/macros.h:12,
[   38s]                  from ../deps/v8/src/libplatform/worker-thread.h:12,
[   38s]                  from ../deps/v8/src/libplatform/worker-thread.cc:5:
[   38s] ../deps/v8/src/base/logging.h: In function 'auto v8::base::detail::GetUnderlyingEnumTypeForPrinting(T)':
[   38s] ../deps/v8/src/base/logging.h:154:26: error: 'uint16_t' was not declared in this scope
[   38s]   154 |                          uint16_t> >;
[   38s]       |                          ^~~~~~~~
[   38s] ../deps/v8/src/base/logging.h:17:1: note: 'uint16_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
[   38s]    16 | #include "src/base/template-utils.h"
[   38s]   +++ |+#include <cstdint>
[   38s]    17 | 
[   38s] ../deps/v8/src/base/logging.h:154:34: error: template argument 3 is invalid
[   38s]   154 |                          uint16_t> >;
[   38s]       |                                  ^

as described here:
https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

Build fine.

Additional information

No response

Activity

  1. mscdex commented on Jul 1, 2022

    @mscdex
    Contributor

    Issues with upstream dependencies should be made on their respective issue trackers. V8's is here.

  2. marxin commented on Jul 1, 2022

    @marxin
    Author
  3. xen0n commented on Oct 10, 2022

    @xen0n

    A fix is just merged at https://chromium-review.googlesource.com/c/v8/v8/+/3934140; we could integrate/backport right away.

  4. gengjiawen commented on Oct 11, 2022

    @gengjiawen
    Member
  5. added a commit that references this issue on Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    v8 engineIssues and PRs related to the V8 dependency.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions