Repository navigation
Can --trace-atomics-wait be removed #42982
Description
Activity
@syg I am personally fine with anything here.
--trace-atomics-waithas been useful for me in the past occasionally, and the thing about it is that it’s useful specifically in situations in which it can be hard to debug with other tools, but if you feel that it’s not worth it, sure, drop it.@syg I am personally fine with anything here. --trace-atomics-wait has been useful for me in the past occasionally, and the thing about it is that it’s useful specifically in situations in which it can be hard to debug with other tools, but if you feel that it’s not worth it, sure, drop it.
Given the current functionality of
--trace-atomics-waittracing theAtomics.waitevents (not using the handle to interrupt waits), is it possible to do that in userland? I guess the problem is that on a failure to wait, regardless of whether you re-read the address after the fact or buffer the address beforehand, there's still no guarantee if that value is what caused it to fail?Another option here is to keep the pre-hook needed for
--trace-atomics-wait, remove the other hooks, as well as the handle. The handle is probably 70% of the complexity I want to remove.- added a commit that references this issue
on Aug 2, 2022 - added a commit that references this issue
on Aug 4, 2022 - added a commit that references this issue
on Aug 16, 2022 - added a commit that references this issue
on Aug 23, 2022 - added a commit that references this issue
on Sep 5, 2022 6 remaining items
There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.
We should probably runtime deprecate it to move forward with this.
Moving to runtime deprecation with #51179
- added a commit that references this issue
on Dec 22, 2023 @syg the flag has moved to runtime deprecation, afaik it will be released in the next major (22).
Reacted by Shu-yu GuoAfter this PR: #52747 it will be completely removed
Reacted by Shu-yu Guo- added a commit that references this issue
on May 1, 2024 - added a commit that references this issue
on Jun 20, 2024
What is the problem this feature will solve?
The V8 API hook (
SetAtomicsWaitCallback) to support--trace-atomics-waitis fairly complex and adds maintenance burden. Further the only user of the API is node, and node only uses a subset of the functionality, and only for diagnostic purposes.Is it feasible to remove this diagnostic functionality? Judging by the original commit message the original motivation was maybe to use the hooks to build a deadlock detection system, not just printf diagnostics. It's been 4 years since then, and if no such system has been prototyped and it's not on the roadmap anytime soon, I'd like to deprecate and remove the V8 API.
cc @addaleax
What is the feature you are proposing to solve the problem?
Remove
--trace-atomics-waitWhat alternatives have you considered?
No response