Skip to content

It should be impossible to construct an AbortSignal manually #36064

Closed
Closed
It should be impossible to construct an AbortSignal manually#36064
Labels
eventtargetIssues and PRs related to the EventTarget implementation.good first issueIssues that are suitable for first-time contributors.

Description

@benjamingr
benjamingr
opened on Nov 10, 2020

In AbortController/AbortSignal it is possible to construct an AbortSignal without a controller (but shouldn't be):

> var c = new AbortController();
> new c.signal.constructor()
AbortSignal { aborted: false }

Correct behavior:

> var c = new AbortController();
new c.signal.constructor()
TypeError: Illegal Constructor

This should be a relatively simple fix but it's a spec compliance issue - so if no new contributor picks this up I'll fix this sometime next week :]

Activity

  1. benjamingr
    added
    good first issueIssues that are suitable for first-time contributors.
    eventtargetIssues and PRs related to the EventTarget implementation.
    on Nov 10, 2020

  2. dev-script commented on Nov 10, 2020

    @dev-script
    dev-script
    on Nov 10, 2020
    Contributor

    @benjamingr , I would like to work on this issue

  3. nodejs-github-bot
    closed this as completedin 22293eaon Nov 14, 2020

  4. benjamingr commented on Nov 14, 2020

    @benjamingr
    benjamingr
    on Nov 14, 2020
    MemberAuthor

    Thanks @RaisinTen !

  5. RaisinTen commented on Nov 14, 2020

    @RaisinTen
    RaisinTen
    on Nov 14, 2020
    Member

    @benjamincburns you're welcome. 🙂

  6. codebytere
    added a commit that references this issue on Nov 22, 2020

    events: disabled manual construction AbortSignal

    1550073
  7. MayaLekova
    added a commit that references this issue on May 22, 2026

    events: disabled manual construction AbortSignal

    22293ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    eventtargetIssues and PRs related to the EventTarget implementation.good first issueIssues that are suitable for first-time contributors.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions