Skip to content

investigate unreliable test-heapdump-http2 #34389

Closed
#34415
Closed
investigate unreliable test-heapdump-http2#34389
#34415
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.http2Issues and PRs related to the http2 subsystem.

Description

@Trott
Trott
opened on Jul 16, 2020

test/pummel/test-heapdump-http2.js is failing when I run it in CI and locally. (It passes the nightly CI on a particular Linux machine, but fails on many other machines when I run it more broadly in CI.)

The error always looks like this:

AssertionError [ERR_ASSERTION]: Expect to find 1 'Node / StreamPipe', found 0
    at State.validateSnapshot (/Users/trott/io.js/test/common/heap.js:122:14)
    at State.validateSnapshotNodes (/Users/trott/io.js/test/common/heap.js:186:10)
    at ClientHttp2Stream.<anonymous> (/Users/trott/io.js/test/pummel/test-heapdump-http2.js:60:11)
    at ClientHttp2Stream.<anonymous> (/Users/trott/io.js/test/common/index.js:365:15)
    at ClientHttp2Stream.emit (events.js:314:20)
    at emit (internal/http2/core.js:299:8)
    at processTicksAndRejections (internal/process/task_queues.js:83:22) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: 0,
  expected: 1,
  operator: 'strictEqual'
}

Activity

  1. addaleax
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    http2Issues and PRs related to the http2 subsystem.
    on Jul 16, 2020

  2. addaleax commented on Jul 16, 2020

    @addaleax
    addaleax
    on Jul 16, 2020
    Member

    What if you replace stream.respondWithFile(__filename); with stream.respondWithFile(process.execPath); in the test file? Maybe the test file is small enough on some operating systems to be sent immediately, without waiting for the receiving side to do anything.

  3. Trott commented on Jul 17, 2020

    @Trott
    Trott
    on Jul 17, 2020
    MemberAuthor

    What if you replace stream.respondWithFile(__filename); with stream.respondWithFile(process.execPath); in the test file? Maybe the test file is small enough on some operating systems to be sent immediately, without waiting for the receiving side to do anything.

    That fixed it for me! 🎉

  4. addaleax commented on Jul 17, 2020

    @addaleax
    addaleax
    on Jul 17, 2020
    Member

    Great :) I think for a pummel test that is an acceptable solution.

  5. Trott
    closed this as completedin a51436con Jul 19, 2020
  6. cjihrig
    added a commit that references this issue on Jul 23, 2020

    test: fix flaky test-heapdump-http2

    17b2881
  7. MylesBorins
    added a commit that references this issue on Jul 27, 2020

    test: fix flaky test-heapdump-http2

    30da332
  8. addaleax
    added 2 commits that reference this issue on Sep 22, 2020

    test: fix flaky test-heapdump-http2

    fb71b90

    test: fix flaky test-heapdump-http2

    cc26431
  9. MayaLekova
    added a commit that references this issue on May 22, 2026

    test: fix flaky test-heapdump-http2

    a51436c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.http2Issues and PRs related to the http2 subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions