Repository navigation
move things away from process.binding('util') #30884
Description
Activity
I will work on this, do you have any specific name for that binding? And what methods should be on that binding.
@juanarbol I guess something like "internal_util" would work (though I am bad at naming stuff). I think you can start by git blaming the
Initializefunction in node_util.cc and starting from the most recent addition.Wasn't this fixed by #37819?
This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.
process.binding('util')has been some kind of hotch-potch of "bindings the JS internals need but don't fall in the scope of a particular binding namespace". There is no compatibility guarantee about what's in this object and changes to it are completely at the whims of Node.js maintainers.However
process.binding('util')has been accessible in the user land and is abused by users (refs: #29947 (comment) - considering how volatile it is, when touching this binding I had always been wondering if anyone actually abuses this, until I saw the issue). I propose we try creating a new, internal namespace (that is, a namespace that's not in the whitelist here) and try moving everything away to that internal namespace to reduce the abuse.On a side note, I think there should be a comment in
node_utils.ccwarning that any additions to the binding is at the risk of user-land abuse.