Repository navigation
http2 compat missing writableFinished #29230
Description
Activity
This is fixed as I test this on
v25.0.0-pre./node/out/Release/node ./node/test/parallel/test-test.js 1 /home/ohmx/Documents/node/test/parallel/test-test.js:30 throw new Error('boom'); ^ Error: boom at Domain.<anonymous> (/home/ohmx/Documents/node/test/parallel/test-test.js:30:11) at Domain.emit (node:events:507:28) at Domain.emit (node:domain:489:12) at Domain._errorHandler (node:domain:279:23) at Object.<anonymous> (node:domain:181:29) at process._fatalException (node:internal/process/execution:158:29) Node.js v25.0.0-preThe
writableFinishedgetter is implemented inlib/internal/http2/compat.js(line 554). I think this issue can be closed.While checking, I noticed
writableObjectModeandwritableNeedDrainare still missing fromHttp2ServerResponsecompared tohttp.OutgoingMessage. Filed #63000 to track that separately.
http2 compat is missing
writableFinishedforOutgoingMessage.I tried fixing this myself but the whole finished flow for http2 compat confuses me.
finishedseems to be looking at a lot of different stuff (e.g. what does abort have to do with finish?).'finish'is emitted onstream.on('close', ...).this.on('finish', ...)and sometimesstream.on('finish', ...).I think someone with a clearer understanding needs to look at this.