Repository navigation
lib: assert.throws('string', TypeError, 'whatever') passes when it shouldn't #275
Description
Activity
The third argument isn't supposed to be validated is it? The documentation doesn't seem to imply that it should. To validate the exception message, the second argument should be a regex or function.
The third argument should be included in the error message though, right? That doesn't seem to be happening.
The third argument is the message to put in the
AssertionError, like like all the other stuff inassert(the last argument is the assertion message).Checking the thrown exception message would be to give a string as the second argument, rather than a constructor (you can also provide a RegExp object as the second argument).
Expects block to throw an error. error can be constructor, RegExp or validation function.
I don't think strings are supported as the second arguments.
Is there a specific reason that the
assertmodule doesn't do a better job at input validation? For example, instead of blindly treating the first argument tothrows()as a function, maybe it should validate that it is actually a function.Alright, seems I was wrong about the third argument. Let me rephrase:
assert.throws('string', TypeError)passes for the wrong reasons. I think it should either throw a TypeError ("first argument must be a function") or eval() the argument, like the assert functions in the SM and V8 test suites.@bnoordhuis +1 on throwing on bad input. I'll work on this.
- added a commit that references this issue
on Jan 12, 2015 Think I like the v8 behavior better there
From here: