Repository navigation
ERR_TLS_RENEGOTIATE, ERR_HTTP2_SETTINGS_CANCEL are not defined #21440
Description
Activity
- addederrorsIssues and PRs related to JavaScript errors originating in Node.js core.Issues and PRs related to JavaScript errors originating in Node.js core.tlsIssues and PRs related to the tls subsystem.Issues and PRs related to the tls subsystem.http2Issues and PRs related to the http2 subsystem.Issues and PRs related to the http2 subsystem.
on Jun 21, 2018 - changed the title
[-]ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK is not defined[/-][+]ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, ERR_TLS_RENEGOTIATE, ERR_HTTP2_SETTINGS_CANCEL are not defined[/+]on Jun 21, 2018 @BridgeAR I am looking only at JS side, not docs.
At 1d2fd8b, there is no
ERR_MISSING_DY***,ERR_TLS_RENEGOTIATEorERR_HTTP2_SETTINGS_CANCELdefined, but those are directly used as properties (for the first time).I could be wrong with interpreting
blameoutput, and those might have been removed earlier.Oh, I only looked at the first entry before the edits.
This is the list of errors that seem to be missing documentation:
ERR_HTTP2_ERROR ERR_UNKNOWN_BUILTIN_MODULE ERR_HTTP2_SETTINGS_CANCEL ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK ERR_TLS_RENEGOTIATEThose are the three mentioned above (that also miss implementation), plus:
ERR_HTTP2_ERROR(used inlib/internal/http2/util.js).ERR_UNKNOWN_BUILTIN_MODULE(used inlib/internal/bootstrap/loaders.js).
- Was never properly ported: f67aa56 (the error code was not created at all).
Reacted by Nikita Skovoroda- Was never properly implemented: bbaea12
Reacted by Nikita SkovorodaERR_UNKNOWN_BUILTIN_MODULEis a false positive. It is actually added to the error directly instead of usinginternal/errors.ERR_HTTP2_ERRORis a false positive as well.@BridgeAR #21440 (comment) is specifically about documentation — I saw how those are created and it's ok that they are not present in
internal/errors, but they should be documented nevertheless if the user might experience those. I do not think that those are false positives.Based on f67aa56, this might also affect v9.x branch.
Oh, true. They were falsely removed in 1cdb41f.
40 remaining items
- added a commit that references this issue
on Jul 3, 2018 - added a commit that references this issue
on Jul 13, 2018 - added a commit that references this issue
on Jul 14, 2018 - added a commit that references this issue
on Aug 23, 2018 - added a commit that references this issue
on Sep 8, 2018 - added a commit that references this issue
on Oct 16, 2018
While taking a look at #21435 / #21421, I did a quick and dirty check which errors are being instantiated and
/liband checked what happened.ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOKseems to be used in loader, but never defined.node/lib/internal/modules/esm/loader.js
Lines 6 to 8 in b56f65e
node/lib/internal/modules/esm/loader.js
Lines 95 to 96 in b56f65e
ERR_TLS_RENEGOTIATEseems to be used in tls, but never defined.node/lib/_tls_wrap.js
Lines 47 to 52 in b56f65e
node/lib/_tls_wrap.js
Lines 572 to 574 in b56f65e
ERR_HTTP2_SETTINGS_CANCELseems to be used in http2, but never defined.node/lib/internal/http2/core.js
Lines 45 to 62 in b56f65e
node/lib/internal/http2/core.js
Lines 615 to 616 in b56f65e
This probably affects all 10.x versions, but was not backported to earlier branches as is a semver-major.
Blame points at 1d2fd8b / #19137.
/cc @targos
This also probably needs a testcase when fixed, I do not have one atm.